Improve registry release reliability #1174
Open
+46
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
killers10
approved these changes
Oct 5, 2025
tonytrg
reviewed
Oct 6, 2025
| build: | ||
| runs-on: ubuntu-latest-xl | ||
| permissions: | ||
| contents: read |
There was a problem hiding this comment.
Do we need to change that to contents write?
There was a problem hiding this comment.
Only changes are local to 'server.json', nothing it written to repo so shouldn't require write permissions to repo itself
tonytrg
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the release workflow to decouple Docker image publishing from MCP Registry publication, ensuring that registry updates only occur after a successful image build and push. The workflows now communicate via a custom GitHub repository dispatch event.
Changes
Registry should be released when docker image is created -> added trigger after docker image release
Registry pipeline should check if image is released and delay if now -> add check and delay